Error analyzer improvements #192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Konicai
commented
Oct 29, 2021
•
Konicai
commented
- Error analyzer is now less case insensitive. The case of the issue string registered in the bot and in the given text shouldn't matter anymore.
- Add/modify some tags
- Add information about issue responses to the tags readme
rtm516
requested changes
Nov 7, 2021
| @@ -108,7 +108,7 @@ public void onMessageReceived(MessageReceivedEvent event) { | |||
| groups[i] = groups[i] == null ? "" : groups[i]; // Replace nulls with empty strings | |||
| } | |||
|
|
|||
| url = String.format(logUrlPatterns.get(regex), groups); | |||
| url = String.format(logUrlPatterns.get(regex), groups); // Casting this to Object breaks something, don't do it | |||
There was a problem hiding this comment.
We should disable the inspector warning along with this comment
There was a problem hiding this comment.
Casting to Object[] should be sufficient right?
rtm516
approved these changes
Dec 1, 2021
# Conflicts: # src/main/java/org/geysermc/discordbot/listeners/ErrorAnalyzer.java # src/main/resources/tags/info/javaversion.tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.