[CI] Create a lane to update StreamChat dependency #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
reviewed
Dec 9, 2024
Comment on lines
+164
to
+172
| file = 'StreamChatSwiftUI.xcodeproj/project.pbxproj' | ||
| content = File.read(file) | ||
| if content.include?("minimumVersion = #{current_stream_chat_version}") | ||
| File.write(file, content.gsub("minimumVersion = #{current_stream_chat_version}", "minimumVersion = #{options[:version]}")) | ||
| elsif content.include?('branch = develop') | ||
| File.write(file, content.gsub('kind = branch', "minimumVersion = #{options[:version]}").gsub('branch = develop', 'kind = upToNextMajorVersion')) | ||
| else | ||
| UI.user_error!("Something went wrong after trying to modify #{file}.") | ||
| end |
There was a problem hiding this comment.
Ideally we should check for stream chat since there are multiple dependencies. Not sure if it is a big deal.
There was a problem hiding this comment.
Yeah, but it actually makes things much more complex. A chance that we will hit a different dependency with the same key minimumVersion = #{current_stream_chat_version} is very low. We also do not use other dependencies from develop ever.
There was a problem hiding this comment.
Yeah, probably fine. We can improve it if really need to. Makes sense to not complicate this too much.
There was a problem hiding this comment.
For now this will work fine 👍 Once we add a new dependency, this will break and then we will know that we need to update this 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolve https://linear.app/stream/issue/IOS-599
🎯 Goal
🧪 Testing