Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update Xcode version #678

Merged
merged 7 commits into from
Dec 5, 2024
Merged

[CI] Update Xcode version #678

merged 7 commits into from
Dec 5, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Dec 4, 2024
@testableapple testableapple requested a review from a team as a code owner December 4, 2024 09:54
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 4, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.09 MB 7.47 MB -632 KB 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

1 Error
🚫 Please start subject with capital letter.
87b3619

Generated by 🚫 Danger

testableapple and others added 2 commits December 4, 2024 12:03
@testableapple
Merge branch 'develop' into ci/xcode-16
3ce09c0
@laevandus
Set SWIFT_ENABLE_OPAQUE_TYPE_ERASURE to NO for StreamChatSwiftUI targ…
cfecb0e 
…et in the Xcode project for avoiding all the view types being wrapped with AnyView
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@testableapple testableapple enabled auto-merge (squash) December 5, 2024 10:16
@testableapple testableapple merged commit 2f8874c into develop Dec 5, 2024
11 of 12 checks passed
@testableapple testableapple deleted the ci/xcode-16 branch December 5, 2024 11:54
laevandus
laevandus reviewed Dec 5, 2024
View reviewed changes
...Channel/__Snapshots__/ReactionsOverlayView_Tests/test_reactionsOverlayView_noReactions.1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slightly different

laevandus
laevandus reviewed Dec 5, 2024
View reviewed changes
...hatChannel/__Snapshots__/ReactionsOverlayView_Tests/test_reactionsOverlayView_snapshot.1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slightly different

nuno-vieira
nuno-vieira approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

laevandus
laevandus reviewed Dec 5, 2024
View reviewed changes
...nnel/__Snapshots__/ReactionsOverlayView_Tests/test_reactionsOverlayView_usersReactions.1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slightly different

...Channel/__Snapshots__/ReactionsOverlayView_Tests/test_reactionsOverlay_veryLongMessage.1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slightly different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laevandus laevandus laevandus left review comments

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testableapple @Stream-SDK-Bot @laevandus @martinmitrevski @nuno-vieira