Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async voice messages #415
Async voice messages #415
Changes from 24 commits
bf513a7
f4c807c
70d113a
15534b7
2309a74
ebae483
3be4e62
87e30f7
066fcf7
10534b8
8ca4d90
b9356a5
e49902f
9c90fc9
e451127
60fe0ee
b1c3718
da3c5f4
28e1045
a5ebe74
21fe6fb
49c36d7
65970c0
8fd872a
de8a7cc
40237e1
1b1f544
d8e13aa
2df6b71
d117be6
5ea98a7
88e486a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one needed? The properties are
var
so probably we can update them in calling place.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to do it in place, but I think it's cleaner with a method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way for integrators to changes this with their own implementation? (Something similar to what Picslo needed a few days ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point, will add a way 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
recording.url
a bookmark? If not,startAccessingSecurityScopedResource
probably isn't necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had issues with regular file attachments because we didn't have this. I would prefer to keep it, unless you see some risks?