PR remarks

GetStream · Dec 19, 2023 · de8a7cc · de8a7cc
1 parent 8fd872a
commit de8a7cc
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 12 deletions.
diff --git a/Sources/StreamChatSwiftUI/ChatChannel/Composer/MessageComposerView.swift b/Sources/StreamChatSwiftUI/ChatChannel/Composer/MessageComposerView.swift
@@ -20,6 +20,8 @@ public struct MessageComposerView<Factory: ViewFactory>: View, KeyboardReadable
     private var channelConfig: ChannelConfig?
     @Binding var quotedMessage: ChatMessage?
     @Binding var editedMessage: ChatMessage?
+
+    private let recordingViewHeight: CGFloat = 80
 
     public init(
         viewFactory: Factory,
@@ -119,7 +121,7 @@ public struct MessageComposerView<Factory: ViewFactory>: View, KeyboardReadable
                         )
                     } else if viewModel.recordingState == .locked || viewModel.recordingState == .stopped {
                         factory.makeComposerRecordingLockedView(viewModel: viewModel)
-                            .frame(height: 80)
+                            .frame(height: recordingViewHeight)
                     } else if viewModel.recordingState == .showingTip {
                         factory.makeComposerRecordingTipView()
                             .offset(y: -composerHeight + 12)
@@ -128,7 +130,7 @@ public struct MessageComposerView<Factory: ViewFactory>: View, KeyboardReadable
                     }
                 }
             )
-            .frame(height: viewModel.recordingState.showsComposer ? nil : 80)
+            .frame(height: viewModel.recordingState.showsComposer ? nil : recordingViewHeight)
 
             if viewModel.sendInChannelShown {
                 factory.makeSendInChannelView(

diff --git a/Sources/StreamChatSwiftUI/ChatChannel/Composer/VoiceRecording/LockedView.swift b/Sources/StreamChatSwiftUI/ChatChannel/Composer/VoiceRecording/LockedView.swift
@@ -81,10 +81,7 @@ struct LockedView: View {
         .offset(y: -20)
         .background(Color(colors.background).edgesIgnoringSafeArea(.bottom))
         .overlay(
-            viewModel.recordingState == .locked ? TopRightView {
-                LockedRecordIndicator()
-            }
-                : nil
+            viewModel.recordingState == .locked ? TopRightView { LockedRecordIndicator() } : nil
         )
         .onAppear {
             player.subscribe(voiceRecordingHandler)

diff --git a/...mChatSwiftUI/ChatChannel/MessageList/AsyncVoiceMessages/VoiceRecordingContainerView.swift b/...mChatSwiftUI/ChatChannel/MessageList/AsyncVoiceMessages/VoiceRecordingContainerView.swift
@@ -103,10 +103,8 @@ struct VoiceRecordingView: View {
                     .foregroundColor(.primary)
                     .modifier(ShadowViewModifier(firstRadius: 2, firstY: 4))
             })
-            .opacity(loading ? 0 : 1)
-            .overlay(
-                loading ? ProgressView() : nil
-            )
+                .opacity(loading ? 0 : 1)
+                .overlay(loading ? ProgressView() : nil)
 
             VStack(alignment: .leading, spacing: 4) {
                 Text(

diff --git a/StreamChatSwiftUITests/Tests/ChatChannel/MessageComposerView_Tests.swift b/StreamChatSwiftUITests/Tests/ChatChannel/MessageComposerView_Tests.swift
@@ -169,7 +169,7 @@ class MessageComposerView_Tests: StreamChatTestCase {
             onTap: {}
         )
         .environmentObject(MessageComposerTestUtils.makeComposerViewModel(chatClient: chatClient))
-        .frame(width: 40, height: 40)
+        .frame(width: 100, height: 40)
 
         // Then
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
@@ -186,7 +186,7 @@ class MessageComposerView_Tests: StreamChatTestCase {
             onTap: {}
         )
         .environmentObject(MessageComposerTestUtils.makeComposerViewModel(chatClient: chatClient))
-        .frame(width: 40, height: 40)
+        .frame(width: 100, height: 40)
 
         // Then
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))

diff --git a/..._Snapshots__/MessageComposerView_Tests/test_trailingComposerView_slowMode.1.png b/..._Snapshots__/MessageComposerView_Tests/test_trailingComposerView_slowMode.1.png
diff --git a/..._Snapshots__/MessageComposerView_Tests/test_trailingComposerView_snapshot.1.png b/..._Snapshots__/MessageComposerView_Tests/test_trailingComposerView_snapshot.1.png