Fix polls background view not using correct color from palette (#667)

* Record dark mode tests in create poll view * Fix Poll Creation View background color * Fix Poll Results background
GetStream · Nov 26, 2024 · 5b54303 · 5b54303
1 parent a90073d
commit 5b54303
Show file tree

Hide file tree

Showing 33 changed files with 15 additions and 15 deletions.
diff --git a/Sources/StreamChatSwiftUI/ChatChannel/MessageList/Polls/PollResultsView.swift b/Sources/StreamChatSwiftUI/ChatChannel/MessageList/Polls/PollResultsView.swift
@@ -55,7 +55,7 @@ struct PollResultsView: View {
                 Spacer()
             }
         }
-        .background(Color(colors.background8).ignoresSafeArea())
+        .background(Color(colors.background).ignoresSafeArea())
         .toolbar {
             ToolbarItem(placement: .principal) {
                 Text(L10n.Message.Polls.Toolbar.resultsTitle)

diff --git a/Sources/StreamChatSwiftUI/ChatChannel/Polls/CreatePollView.swift b/Sources/StreamChatSwiftUI/ChatChannel/Polls/CreatePollView.swift
@@ -162,7 +162,7 @@ struct CreatePollView: View {
                 Spacer()
                     .modifier(ListRowModifier())
             }
-            .background(Color(colors.background8).ignoresSafeArea())
+            .background(Color(colors.background).ignoresSafeArea())
             .listStyle(.plain)
             .id(listId)
             .toolbar {
@@ -237,7 +237,7 @@ struct ListRowModifier: ViewModifier {
         if #available(iOS 15.0, *) {
             content
                 .listRowSeparator(.hidden)
-                .listRowBackground(Color(colors.background8))
+                .listRowBackground(Color(colors.background))
         } else {
             content
         }

diff --git a/StreamChatSwiftUITests/Tests/ChatChannel/CreatePollView_Tests.swift b/StreamChatSwiftUITests/Tests/ChatChannel/CreatePollView_Tests.swift
@@ -19,9 +19,9 @@ final class CreatePollView_Tests: StreamChatTestCase {
         .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
-    
+
     func test_createPollView_allOptionsDisabledSnapshot() {
         // Given
         let hidden = PollsEntryConfig(configurable: false, defaultValue: false)
@@ -38,7 +38,7 @@ final class CreatePollView_Tests: StreamChatTestCase {
         .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_createPollView_allOptionsEnabledSnapshot() {
@@ -58,7 +58,7 @@ final class CreatePollView_Tests: StreamChatTestCase {
         .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_createPollView_mixedOptionsSnapshot() {
@@ -81,6 +81,6 @@ final class CreatePollView_Tests: StreamChatTestCase {
         .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 }
diff --git a/StreamChatSwiftUITests/Tests/ChatChannel/PollAttachmentView_Tests.swift b/StreamChatSwiftUITests/Tests/ChatChannel/PollAttachmentView_Tests.swift
@@ -31,7 +31,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
         .frame(width: defaultScreenSize.width, height: 240)
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_snapshotUniqueVotes() {
@@ -59,7 +59,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
         .frame(width: defaultScreenSize.width, height: 150)
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_closedPoll() {
@@ -88,7 +88,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
         .frame(width: defaultScreenSize.width, height: 150)
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_resultsSnapshot() {
@@ -101,7 +101,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
             .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_allOptions() {
@@ -114,7 +114,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
             .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_allVotes() {
@@ -126,7 +126,7 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
             .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 
     func test_pollAttachmentView_allComments() {
@@ -145,6 +145,6 @@ final class PollAttachmentView_Tests: StreamChatTestCase {
         .applyDefaultSize()
 
         // Then
-        assertSnapshot(matching: view, as: .image)
+        AssertSnapshot(view, variants: .onlyUserInterfaceStyles)
     }
 }
diff --git a/...ePollView_Tests/test_createPollView_allOptionsDisabledSnapshot.default-dark.png b/...ePollView_Tests/test_createPollView_allOptionsDisabledSnapshot.default-dark.png
diff --git a/...PollView_Tests/test_createPollView_allOptionsDisabledSnapshot.default-light.png b/...PollView_Tests/test_createPollView_allOptionsDisabledSnapshot.default-light.png
diff --git a/...tePollView_Tests/test_createPollView_allOptionsEnabledSnapshot.default-dark.png b/...tePollView_Tests/test_createPollView_allOptionsEnabledSnapshot.default-dark.png
diff --git a/...ePollView_Tests/test_createPollView_allOptionsEnabledSnapshot.default-light.png b/...ePollView_Tests/test_createPollView_allOptionsEnabledSnapshot.default-light.png
diff --git a/.../CreatePollView_Tests/test_createPollView_mixedOptionsSnapshot.default-dark.png b/.../CreatePollView_Tests/test_createPollView_mixedOptionsSnapshot.default-dark.png
diff --git a/...CreatePollView_Tests/test_createPollView_mixedOptionsSnapshot.default-light.png b/...CreatePollView_Tests/test_createPollView_mixedOptionsSnapshot.default-light.png
diff --git a/..._Snapshots__/CreatePollView_Tests/test_createPollView_snapshot.default-dark.png b/..._Snapshots__/CreatePollView_Tests/test_createPollView_snapshot.default-dark.png
diff --git a/...Snapshots__/CreatePollView_Tests/test_createPollView_snapshot.default-light.png b/...Snapshots__/CreatePollView_Tests/test_createPollView_snapshot.default-light.png
diff --git a/..._Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allComments.1.png b/..._Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allComments.1.png
diff --git a/..._/PollAttachmentView_Tests/test_pollAttachmentView_allComments.default-dark.png b/..._/PollAttachmentView_Tests/test_pollAttachmentView_allComments.default-dark.png
diff --git a/.../PollAttachmentView_Tests/test_pollAttachmentView_allComments.default-light.png b/.../PollAttachmentView_Tests/test_pollAttachmentView_allComments.default-light.png
diff --git a/...__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.1.png b/...__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.1.png
diff --git a/...__/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.default-dark.png b/...__/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.default-dark.png
diff --git a/..._/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.default-light.png b/..._/PollAttachmentView_Tests/test_pollAttachmentView_allOptions.default-light.png
diff --git a/...l/__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.1.png b/...l/__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.1.png
diff --git a/...ts__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.default-dark.png b/...ts__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.default-dark.png
diff --git a/...s__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.default-light.png b/...s__/PollAttachmentView_Tests/test_pollAttachmentView_allVotes.default-light.png
diff --git a/...__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.1.png b/...__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.1.png
diff --git a/...__/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.default-dark.png b/...__/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.default-dark.png
diff --git a/..._/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.default-light.png b/..._/PollAttachmentView_Tests/test_pollAttachmentView_closedPoll.default-light.png
diff --git a/...pshots__/PollAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.1.png b/...pshots__/PollAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.1.png
diff --git a/...llAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.default-dark.png b/...llAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.default-dark.png
diff --git a/...lAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.default-light.png b/...lAttachmentView_Tests/test_pollAttachmentView_resultsSnapshot.default-light.png
diff --git a/...tachmentView_Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.1.png b/...tachmentView_Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.1.png
diff --git a/...w_Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.default-dark.png b/...w_Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.default-dark.png
diff --git a/..._Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.default-light.png b/..._Tests/test_pollAttachmentView_snapshotCommentsAndSuggestions.default-light.png
diff --git a/...ts__/PollAttachmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.1.png b/...ts__/PollAttachmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.1.png
diff --git a/...tachmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.default-dark.png b/...tachmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.default-dark.png
diff --git a/...achmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.default-light.png b/...achmentView_Tests/test_pollAttachmentView_snapshotUniqueVotes.default-light.png