Quoted message preview did not update when the quoted message was deleted #3553
+117
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🐞 Bug
laevandus
commented
Jan 8, 2025
| @@ -170,7 +170,7 @@ open class QuotedChatMessageView: _View, ThemeProvider, SwiftUIRepresentable { | |||
| ? appearance.colorPalette.popoverBackground | |||
| : appearance.colorPalette.highlightedAccentBackground1 | |||
|
|
|||
| setText(message.text) | |||
| setText(message.textContent ?? "") | |||
There was a problem hiding this comment.
textContent internally checks for the deleted state
laevandus
commented
Jan 8, 2025
| isSentByCurrentUser: true | ||
| ) | ||
| view.content = QuotedChatMessageView.Content(message: message, avatarAlignment: .leading) | ||
| AssertSnapshot(view) |
There was a problem hiding this comment.
I am not sure how to force the snapshot test to capture the grey text color. This works OK in the demo app, but snapshot test uses whatever textView.textColor is. I did not want to overcomplicate this so I left it as is. Seems to be related to order of things when view is rendered.
SDK Size
|
SDK Performance
|
laevandus
force-pushed
the
fix/quoted-message-refresh
branch
from
a7edef7 to
cc67896
Compare
SDK Size
|
laevandus
changed the title
4 tasks
nuno-vieira
approved these changes
Jan 8, 2025
martinmitrevski
approved these changes
Jan 8, 2025
testableapple
added
🟢 QAed
testableapple
approved these changes
Jan 9, 2025
|
laevandus
force-pushed
the
fix/quoted-message-refresh
branch
from
0f271ea to
c62daad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-478
🎯 Goal
When quoted message was deleted, then it did not refresh
📝 Summary
🛠 Implementation
Manually trigger refreshes for quoted by messages (messages showing the quoted message view)
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo