Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable test_databaseContainer_removesAllData_whenShouldFlushOnStartIsTrue test #3336

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

laevandus
Copy link
Contributor

🎯 Goal

  • Fix test which had race between one instance deleting the local DB file and another instance reading it

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

…ushOnStartIsTrue sometimes failed because deinit was cleaning up file on disk while another instance was reading it
@laevandus laevandus added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🤖 CI/CD Any work related to CI/CD labels Jul 25, 2024
@laevandus laevandus requested a review from a team as a code owner July 25, 2024 10:12
Copy link

@laevandus laevandus merged commit 18e72ed into develop Jul 25, 2024
16 checks passed
@laevandus laevandus deleted the ci/database-unstable-unit-test branch July 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI/CD Any work related to CI/CD 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants