Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MissingConnectionId + InvalidURL + InvalidJSON Errors #3332

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Expose MissingConnectionId + InvalidURL + InvalidJSON Errors #3332

merged 5 commits into from
Jul 24, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jul 24, 2024 •
edited
Loading

🔗 Issue Links

None

🎯 Goal

Expose Errors that are useful for some customers.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira requested a review from a team as a code owner July 24, 2024 14:56
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

StreamChat StreamChatUI Total
6.7MB 4.4MB 11.1MB

@nuno-vieira nuno-vieira marked this pull request as draft July 24, 2024 18:17
@nuno-vieira nuno-vieira marked this pull request as ready for review July 24, 2024 18:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
141 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.7MB 6.7MB 0.0MB 🟢
StreamChatUI 4.4MB 4.4MB 0.0MB 🟢

@nuno-vieira nuno-vieira merged commit e4931b7 into develop Jul 24, 2024
15 of 16 checks passed
@nuno-vieira nuno-vieira deleted the add/expose-missing-connection-id-errors branch July 24, 2024 18:30
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @laevandus