Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.43.0 Release #2898

Merged
merged 13 commits into from
Nov 20, 2023
Merged

4.43.0 Release #2898

merged 13 commits into from
Nov 20, 2023

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Nov 17, 2023

StreamChat

✅ Added

  • Add new NewMessageErrorEvent when observing EventsController #2885

StreamChatUI

✅ Added

  • Add jump to unread messages interaction #2894
  • Add support for opening a channel in the unread messages page with Components.shouldJumpToUnreadWhenOpeningChannel #2894

StreamChatUI

🐞 Fixed

  • Fix Message List UI not updated when message.updatedAt changes #2884
  • Fix jump to unread button showing "0" unread counts #2894
  • Fix not able to mark channel read when isJumpToUnread is disabled #2902

ipavlidakis and others added 11 commits November 14, 2023 18:45
* Fix updatedAt changes not triggering UI updates

* Make sure that updatedAt is changed locally

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Martin Mitrevski <[email protected]>
* Add new `NewMessageErrorEvent` to observe when a message fails to be sent

* Update CHANGELOG.md

* Make sure NewMessageErrorEvent is immutable

* PR Feedback

* Update CHANGELOG.md
* Unify Database clearing logic under DatabaseObserverRemovalListener

* Minor fixes

* Do not performAndWait on LazyCachedMapCollection when in BG Mapping

* Fix implementation for DatabaseObserverRemovalListener when in foreground

* Move NSManagedObjectContext's reset when removing data to DatabaseContainer

* Only reset contexts when Background Mapping is enabled

* Fix existing tests

---------

Co-authored-by: Alexey Alter-Pesotskiy <[email protected]>
* Move all remaining usage of ListDatabaseObserver to the wrapper

* Fix existing tests

* Address PR comments
* Add Jump to Unread Button Interaction

* Fix showing 0 unread count in jump to unread button

* Add test coverage

* Add `Components.shouldJumpToUnreadWhenOpeningChannel`

* Update CHANGELOG.md

* Only throttle mark unread when scrolling or messages are updated

* Fix Jump to Unread Button not hiding instantly when tapping discard

* Fix Xcode 14 Build

* Update CHANGELOG.md

* Update CHANGELOG.md

* Flaky test

---------

Co-authored-by: Alexey Alter-Pesotskiy <[email protected]>
@testableapple testableapple requested a review from a team as a code owner November 17, 2023 14:07
Copy link

emerge-tools bot commented Nov 17, 2023

1 build increased size

Name Version Download Change Install Change
ChatSample
io.getstream.iOS.ChatDemoApp
1.0 (1) 4.4 MB ⬆️ 12.8 kB (0.29%) 12.5 MB ⬆️ 68.1 kB (0.55%)

ChatSample 1.0 (1)
io.getstream.iOS.ChatDemoApp

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 68.1 kB (0.55%)
Total download size change: ⬆️ 12.8 kB (0.29%)

Largest size changes

Item Install Size Change
📝 StreamChat.DatabaseObserverRemovalListener.listenForRemoveAllData... ⬆️ 43.6 kB
DYLD.String Table ⬆️ 13.9 kB
StreamChat.ListDatabaseObserver.listenForRemoveAllDataNotificatio... ⬇️ -12.6 kB
StreamChat.EntityDatabaseObserver.listenForRemoveAllDataNotificat... ⬇️ -8.1 kB
StreamChat.BackgroundDatabaseObserver.listenForRemoveAllDataNotif... ⬇️ -7.8 kB

Image of diff


🛸 Powered by Emerge Tools

Copy link

Build for regression testing №123456958 has been uploaded to TestFlight 🎁

* Fix flaky test

* Fix not jumping to reply inside thread when opening channel

* Add test coverage to avoid regressions
Copy link

Build for regression testing №123456959 has been uploaded to TestFlight 🎁

* Fix not being able to mark channel read when `isJumpToUnread` is disabled

* Update CHANGELOG.md
Copy link

Build for regression testing №123456960 has been uploaded to TestFlight 🎁

@testableapple testableapple merged commit ec8c625 into main Nov 20, 2023
14 of 16 checks passed
@testableapple testableapple deleted the release/4.43.0 branch November 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants