Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.38.0 Release #2816

Merged
merged 14 commits into from
Sep 29, 2023
Merged

4.38.0 Release #2816

merged 14 commits into from
Sep 29, 2023

Conversation

nuno-vieira
Copy link
Member

StreamChat

✅ Added

  • Message parameter in adding/removing members methods #2799

🐞 Fixed

  • Fix thread-safety issues when connection waiters time out #2814

StreamChatUI

⚡ Performance

  • Add throttling to mark as read #2808
  • Improve efficiency when skipping messages #2809
  • Revert message updates whenever user info changes #2810
  • Improve efficiency when diffing ChatMessage #2811

🐞 Fixed

  • Fix skipping messages logic when not scrolled fully to the bottom #2809

🔄 Changed

  • When there are user updates the message list won't update the authors instantly #2810
    • This was recently introduced here but impacted too much the performance.

polqf and others added 14 commits September 26, 2023 13:47
@polqf
Release fix: Do not mark as read new unseen messages (#2805)
82472e6 
* Do not mark as read when new messages come in and are unseen

* Mark as read when tapping scroll to bottom button

* Fix tests for ChatChannelVC
@polqf
Release fix: Truncation related fixes for mark as/jump to unread (#2806)
5609ed5 
* Reset read for truncated messages

* Allow automatic marking as read when discarding unread messages

* Make sure we can mark as read if the last message was seen or is currently on screen
@polqf
Merge branch 'main' into develop
e6cafa7
@martinmitrevski
Added a message parameter in adding/removing members methods (#2799)
68c2908
@nuno-vieira
Fix thread-safety of connection waiter when timing out (#2814)
6f84089 
* Fix thread-safety of connection waiter when timing out

* Update CHANGELOG.md
@polqf @nuno-vieira
Add throttling to mark as read (#2808)
561425e
@nuno-vieira
Fix skipping messages logic + performance improvements (#2809)
0ae928a 
* Fix skipping messages logic + performance improvements

* Improve efficiency of threads

* PR Feedback
@nuno-vieira
Revert message updates whenever user info changes (#2810)
59ac70b
@polqf @nuno-vieira
Improve performace of ChatMessage.isContentEqual(to:) (#2811)
1198550
@polqf @nuno-vieira
Perf/leftovers (#2812)
88abb33 
* Fix ChatChannelVC specs

* Introduce threadParticipantsCount to improve comparison of ChatMessage

* Clean up equatable tests
@nuno-vieira
Update CHANGELOG.md
660a3b5
@nuno-vieira
Skip E2E Test for message read (for now)
5255e33
@nuno-vieira
Fix Xcode 13 Build
1955e71
@nuno-vieira
Bump 4.38.0
8d27671
@nuno-vieira nuno-vieira requested a review from a team as a code owner September 29, 2023 12:40
@emerge-tools
Copy link

emerge-tools bot commented Sep 29, 2023

1 build increased size

Name Version Download Change Install Change
ChatSample 1.0 (1) 4.3 MB ⬆️ 4.6 kB (0.11%) 12.1 MB ⬆️ 20.8 kB (0.17%)

ChatSample 1.0 (1)

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 20.8 kB (0.17%)
Total download size change: ⬆️ 4.6 kB (0.11%)

Largest size changes

Item Install Size Change
🗑 StreamChatUI.ChatMessageListVC.addSkippedMessagesIfNeeded(with,ne... ⬇️ -2.3 kB
StreamChat.CoreDataLazy.wrappedValue ⬆️ 2.0 kB
📝 StreamChatUI.ChatMessageListVC.shouldSkipMessages(with,newestChan... ⬆️ 1.7 kB
📝 StreamChatUI.Throttler.throttle ⬆️ 1.5 kB
📝 StreamChat.ChatChannelController.addMembers(userIds,hideHistory,m... ⬆️ 1.4 kB

Image of diff

🛸 Powered by Emerge Tools

@github-actions
Copy link

Build for regression testing №123456946 has been uploaded to TestFlight 🎁

@nuno-vieira nuno-vieira merged commit 8d27671 into main Sep 29, 2023
12 of 15 checks passed
@nuno-vieira nuno-vieira deleted the release/4.38.0 branch September 29, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @polqf @martinmitrevski