#441 - fixed issue with rel attribute for links in the post editor

GetPublii · May 11, 2019 · 9e6b868 · 9e6b868
1 parent 988e83e
commit 9e6b868
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/app/back-end/builddata.json b/app/back-end/builddata.json
@@ -1 +1 @@
-{"version":"0.34.0","build":11730,"status":"Beta"}
+{"version":"0.34.0","build":11733,"status":"Beta"}
diff --git a/app/src/components/post-editor/InlineEditor.vue b/app/src/components/post-editor/InlineEditor.vue
@@ -89,6 +89,12 @@ export default {
 
                 if (response.rel) {
                     relAttr = ' rel="nofollow"';
+
+                    if (response.target.indexOf('_blank') > -1) {
+                        relAttr = ' rel="nofollow noopener noreferrer"';
+                    }
+                } else if (response.target.indexOf('_blank') > -1) {
+                    relAttr = ' rel="noopener noreferrer"';
                 }
 
                 let linkHTML = `<a href="${response.url}"${response.title}${response.target}${relAttr}>${response.text}</a>`;

diff --git a/app/src/components/post-editor/LinkPopup.vue b/app/src/components/post-editor/LinkPopup.vue
@@ -269,7 +269,7 @@ export default {
                 }
             }
 
-            if (relContent && relContent[1]) {
+            if (relContent && relContent[1].indexOf('nofollow') > -1) {
                 this.rel = true;
             }
         },

diff --git a/app/src/components/post-editor/LinkToolbar.vue b/app/src/components/post-editor/LinkToolbar.vue
@@ -46,6 +46,12 @@ export default {
 
                 if (response.rel) {
                     relAttr = ' rel="nofollow"';
+
+                    if (response.target.indexOf('_blank') > -1) {
+                        relAttr = ' rel="nofollow noopener noreferrer"';
+                    }
+                } else if (response.target.indexOf('_blank') > -1) {
+                    relAttr = ' rel="noopener noreferrer"';
                 }
 
                 let linkHTML = `<a href="${response.url}"${response.title}${response.target}${relAttr}>${response.text}</a>`;
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		{"version":"0.34.0","build":11730,"status":"Beta"}
		{"version":"0.34.0","build":11733,"status":"Beta"}
-Original file line number
+Diff line change
@@ Expand Up / @@ -269,7 +269,7 @@ export default { @@
                     }
                 }
-                if (relContent && relContent[1]) {
+                if (relContent && relContent[1].indexOf('nofollow') > -1) {
                     this.rel = true;
                 }
             },
@@ Expand Down @@