Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added estimator madogram #332

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ibkvictor
Copy link

added estimator F - madogram

|f_diff|

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor,

I am truly sorry for keeping you waiting so long for a response! I like the idea of supporting the madogram. But before we can merge your PR, there are a few small things I would like to see changed.

The new functionality is not mentioned anywhere in the docstrings. Could you add some text to the docstring of the vario_estimate function in the file variogram.py? And could you also add a few simple unit tests?
Apart from those two points and the very small comments I made inline, I think we are nearly good to go. Thanks again!

Cheers,
Lennart

src/gstools/variogram/variogram.py Outdated Show resolved Hide resolved
src/gstools/variogram/estimator.pyx Show resolved Hide resolved
src/gstools/variogram/variogram.py Outdated Show resolved Hide resolved
based on commit resolve discussion.

estimator changed to `a`.
included relevant citation.
@LSchueler
Copy link
Member

Thank you for the changes.
However, now there is an inconsistency between the argument to choose your estimator, which is "madogram" and the docstring describing the estimator, which is "f-madogram". Please fix that.
And another problem in the docstring is the missing references. Have a look at the last lines of the docstring

    References
    ----------
    .. [Webster2007] Webster, R. and Oliver, M. A.
           "Geostatistics for environmental scientists.",
           John Wiley & Sons. (2007)

You should include your references there too and then you can link them via [Cooley2006]_ and [Neves2011]_.

@MuellerSeb MuellerSeb marked this pull request as draft July 15, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants