Add git cion score to donation flow #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nation in qacc service
MohammadPCh
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
@ae2079 Thanks for the PR! It looks great to me, but since Carlos is the HERO of this part, I’d recommend having him review it as well to ensure everything is spot on. 😊
|
Also, @aminlatifi is the Hero of this part |
aminlatifi
requested changes
Nov 25, 2024
aminlatifi
requested changes
Nov 25, 2024
aminlatifi
requested changes
Nov 25, 2024
aminlatifi
reviewed
Nov 25, 2024
change env variables names Co-authored-by: Amin Latifi <[email protected]>
aminlatifi
requested changes
Nov 26, 2024
aminlatifi
requested changes
Nov 26, 2024
aminlatifi
approved these changes
Nov 26, 2024
config/example.env
Outdated
| GITCOIN_PASSPORT_MIN_VALID_ANALYSIS_SCORE= | ||
| # 1 day | ||
| GITCOIN_PASSPORT_EXPIRATION_PERIOD_MS=86400000 | ||
| MAX_CONTRIBUTION_WITH_GITCOIN_PASSPORT_ONLY_IN_USD= |
There was a problem hiding this comment.
Suggested change
| MAX_CONTRIBUTION_WITH_GITCOIN_PASSPORT_ONLY_IN_USD= | |
| MAX_CONTRIBUTION_WITH_GITCOIN_PASSPORT_ONLY_USD= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.