Merge pull request #44 from GeneralMagicio/setDefaultValueForProjectS…

…tatuses Set default value for project statuses
GeneralMagicio · Sep 3, 2024 · df8581c · df8581c
2 parents 5d27480 + a7d51cb
commit df8581c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/src/entities/project.ts b/src/entities/project.ts
@@ -423,7 +423,7 @@ export class Project extends BaseEntity {
   @Column({
     type: 'enum',
     enum: ReviewStatus,
-    default: ReviewStatus.NotReviewed,
+    default: ReviewStatus.Listed,
   })
   reviewStatus: ReviewStatus;
 

diff --git a/src/resolvers/projectResolver.test.ts b/src/resolvers/projectResolver.test.ts
@@ -459,11 +459,10 @@ function createProjectTestCases() {
       ORGANIZATION_LABELS.GIVETH,
     );
 
-    // When creating project, listed is null by default
-    assert.equal(result.data.data.createProject.listed, null);
+    assert.equal(result.data.data.createProject.listed, true);
     assert.equal(
       result.data.data.createProject.reviewStatus,
-      ReviewStatus.NotReviewed,
+      ReviewStatus.Listed,
     );
 
     assert.equal(
@@ -568,11 +567,10 @@ function createProjectTestCases() {
       ORGANIZATION_LABELS.GIVETH,
     );
 
-    // When creating project, listed is null by default
-    assert.equal(result.data.data.createProject.listed, null);
+    assert.equal(result.data.data.createProject.listed, true);
     assert.equal(
       result.data.data.createProject.reviewStatus,
-      ReviewStatus.NotReviewed,
+      ReviewStatus.Listed,
     );
 
     assert.equal(

diff --git a/src/resolvers/projectResolver.ts b/src/resolvers/projectResolver.ts
@@ -1118,8 +1118,8 @@ export class ProjectResolver {
     }
     project.qualityScore = qualityScore;
     project.updatedAt = new Date();
-    project.listed = null;
-    project.reviewStatus = ReviewStatus.NotReviewed;
+    project.listed = true;
+    project.reviewStatus = ReviewStatus.Listed;
 
     // if (newProjectData.icon !== undefined) {
     //   project.icon = newProjectData.icon;
@@ -1364,6 +1364,7 @@ export class ProjectResolver {
     }
     const slug = await getAppropriateSlug(slugBase);
 
+    // if we don't get isDraft, we set the status to active
     const status = await this.projectStatusRepository.findOne({
       where: {
         id: projectInput.isDraft ? ProjStatus.drafted : ProjStatus.active,
@@ -1418,6 +1419,9 @@ export class ProjectResolver {
       verified: false,
       giveBacks: false,
       adminUser: user,
+      // make project listed by default
+      listed: true,
+      reviewStatus: ReviewStatus.Listed,
     });
 
     await project.save();
@@ -2145,8 +2149,8 @@ export class ProjectResolver {
         user,
       });
 
-      project.listed = null;
-      project.reviewStatus = ReviewStatus.NotReviewed;
+      project.listed = true;
+      project.reviewStatus = ReviewStatus.Listed;
 
       await project.save();