Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: room page style and join room logic #420

Merged
merged 11 commits into from
Nov 10, 2024
Merged

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • 調整遊戲房間的樣式
  • 修正進入房間的邏輯
  • 逐步調整專案架構

Changes made:

  • user card
  • room page
  • icon and script
  • breadcrumb component
  • add box fancy style

Test Scope / Change impact:

  • breadcrumb component test

Issue

  • none

@JohnsonMao JohnsonMao self-assigned this Nov 10, 2024
@github-actions github-actions bot added the refactor refactor the changes already merged. label Nov 10, 2024
Copy link

@GaaSBot
Copy link

GaaSBot commented Nov 10, 2024

Knip Scan Result for 4aac061

Unused files (8)
Unused files (8)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/iconConverter/IconTemplate.tsx
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exports in namespaces (1)
Unused exports in namespaces (1)
BreadcrumbItem components/shared/Breadcrumb/Breadcrumb.tsx
Unused exported types (3)
Unused exported types (3)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (2)
Unused exported types in namespaces (2)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
BreadcrumbItemProps interface components/shared/Breadcrumb/Breadcrumb.tsx
Unused exported enum members (1)
Unused exported enum members (1)
PRIMARY_TRANSPARENT ButtonVariant components/shared/Button/v2/Button.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Nov 10, 2024

🤖 Lighthouse Scan Result for 4aac061

/rooms
Metric Value
Performance 76
Seo 90
Accessibility 84
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 74
Seo 90
Accessibility 84
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 69
Seo 90
Accessibility 97
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit 9df70cb into main Nov 10, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the refactor/room branch November 10, 2024 12:02
@JohnsonMao JohnsonMao restored the refactor/room branch November 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants