Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: modal v2 and update home page modal #419

Merged
merged 27 commits into from
Nov 2, 2024
Merged

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented Nov 2, 2024

Why need this change? / Root cause:

  • 彈窗樣式改變
  • 建立遊戲房表單欄位調整
  • 遊戲卡片按鈕功能
  • 重構密碼元件
  • 重構圖片元件
  • 調整部分元件樣式與修正 bug
  • 修正輸入框元件點擊邊緣無反應問題

Changes made:

  • 調整目前所有彈窗
  • 調整輸入框元件
  • 調整密碼元件
  • 調整 header 與 sidebar active 樣式

Test Scope / Change impact:

  • Cover 圖片元件測試
  • Input 輸入框元件測試
  • InputOTP 密碼元件測試
  • 彈窗元件測試

Issue

@JohnsonMao JohnsonMao self-assigned this Nov 2, 2024
@github-actions github-actions bot added the feature New Feature label Nov 2, 2024
Copy link

sonarqubecloud bot commented Nov 2, 2024

@GaaSBot
Copy link

GaaSBot commented Nov 2, 2024

Knip Scan Result for 3dece29

Unused files (8)
Unused files (8)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/iconConverter/IconTemplate.tsx
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (3)
Unused exported types (3)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Unused exported enum members (1)
Unused exported enum members (1)
PRIMARY_TRANSPARENT ButtonVariant components/shared/Button/v2/Button.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Nov 2, 2024

🤖 Lighthouse Scan Result for 3dece29

/rooms
Metric Value
Performance 73
Seo 89
Accessibility 80
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 65
Seo 89
Accessibility 82
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 70
Seo 90
Accessibility 97
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit f566913 into main Nov 2, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the feature/carousel-v2 branch November 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog Component
2 participants