chore: fix storybook and sonar cloud issue

Game-as-a-Service · Oct 26, 2024 · 73f812c · 73f812c
1 parent decb2b0
commit 73f812c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/components/shared/Carousel/v2/Carousel.stories.tsx b/components/shared/Carousel/v2/Carousel.stories.tsx
@@ -21,8 +21,11 @@ const meta: Meta<typeof Carousel> = {
     },
   ],
   args: {
-    renderKey: (props: any) => props.name,
-    items: [{ name: "TEST 1" }, { name: "TEST 2" }, { name: "TEST 3" }],
+    items: [
+      { id: 1, name: "TEST 1" },
+      { id: 2, name: "TEST 2" },
+      { id: 3, name: "TEST 3" },
+    ],
     Component: Card,
   },
   argTypes: {

diff --git a/components/shared/Carousel/v2/CarouselContext.tsx b/components/shared/Carousel/v2/CarouselContext.tsx
@@ -87,7 +87,7 @@ export function CarouselProvider<Item extends TItem>({
   items,
   Component,
   renderKey = (item) => item.id,
-}: CarouselProviderProps<Item>) {
+}: Readonly<CarouselProviderProps<Item>>) {
   const [state, dispatch] = useReducer(reducer<Item>, {
     ...initialState,
     items,

diff --git a/pages/index.tsx b/pages/index.tsx
@@ -70,6 +70,7 @@ function CarouselCard({
     <div
       className="flex text-white px-12 gap-4"
       onMouseLeave={() => setOpen(false)}
+      role="menuitem"
     >
       <div className="relative flex items-end justify-end flex-[60%]">
         <Image
@@ -103,6 +104,7 @@ function CarouselCard({
               <div
                 className="absolute bottom-full right-0 mb-2"
                 onMouseLeave={() => setOpen(false)}
+                role="menuitem"
               >
                 <ul className="py-4 effect-new-2 text-primary-800 bg-primary-200/60 whitespace-nowrap rounded-lg">
                   <li>