Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: List Transactions #191

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: List Transactions #191

wants to merge 5 commits into from

Conversation

eshanvaid
Copy link
Contributor

This PR introduces the transactions command, which allows users to retrieve transaction details.

Usage: galoy-cli transactions [OPTIONS]

Options:
-l, --last <LAST>
-f, --first <FIRST>

The first option displays the first specified number of transactions for the logged-in user, and the last option does the same for the last specified number of transactions. If neither first nor last option is provided, the command lists all transactions for the user.

Note that pagination is currently not handled by the gql query to the backend; instead, it is being managed at the app layer. The app filters through all the transactions based on the given input. Once the query has been fixed, the pagination will be handled on the backend, and additional options named before, after, and wallet-ids will be added.

@eshanvaid eshanvaid added the enhancement New feature or request label Aug 2, 2023
@eshanvaid eshanvaid requested a review from sandipndev August 2, 2023 20:55
@eshanvaid eshanvaid self-assigned this Aug 2, 2023
@nicolasburtey
Copy link
Member

I think default should be --last instead of --all

--all should be an explicit option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants