chore: make batch interactive #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
force-pushed
the
chore-make-batch-interactive
branch
from
47c3f07 to
d6398cd
Compare
bodymindarts
approved these changes
Sep 2, 2022
Comment on lines
+201
to
+211
| println!("do you want to confirm? y/n"); | ||
|
|
||
| let mut input = String::new(); | ||
|
|
||
| io::stdin() | ||
| .read_line(&mut input) | ||
| .expect("error: unable to read user input"); | ||
|
|
||
| if !(input.trim() == "y" || input.trim() == "yes") { | ||
| bail!("didn't confirm batch payment. exiting") | ||
| } |
There was a problem hiding this comment.
TBH I've never written any rust that had interaction like this so I don't know if there is a library or a standard convention on how to do this. Would have to go looking at other code to know if there is a better way.
Without doing any research I'd say this looks fine.
You could avoid the double call to trim but afaict it doesn't allocate so is negligible for this use-case.
There was a problem hiding this comment.
looking at https://lib.rs/command-line-interface, maybe dialoguer could be used https://github.com/mitsuhiko/dialoguer
There was a problem hiding this comment.
|
@eshanvaid this could be a good PR to take inspiration from about how to bring about batch payment. |
sandipndev
force-pushed
the
main
branch
4 times, most recently
from
64ab5f2 to
330afe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.