Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ffmpeg to build #46

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

k1nho
Copy link
Contributor

@k1nho k1nho commented Jun 20, 2024

Description

This PR adds FFmpeg dynamically to the build step. This allows users to not have to worry about installing FFmpeg on their own machine (MacOs at the moment)

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

closes #45

[optional] What gif best describes this PR or how it makes you feel?

@k1nho k1nho force-pushed the feat/add-ffmpeg-check-guard-on-startup branch 7 times, most recently from c485554 to 3f9d59d Compare June 24, 2024 17:34
@k1nho k1nho force-pushed the feat/add-ffmpeg-check-guard-on-startup branch from 3f9d59d to 9e0be03 Compare June 24, 2024 17:40
@k1nho k1nho merged commit 3efe596 into beta Jun 24, 2024
2 checks passed
@k1nho k1nho deleted the feat/add-ffmpeg-check-guard-on-startup branch June 24, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature: ship ffmpeg on build
1 participant