Save ore veins with their string id #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes look good to me. Has this been tested in new and old worlds? |
|
Yep tested in an old world with around 45k veins in the server cache and it looked like everything converted correctly. Nothing's really changed for new worlds it'll just save a string instead of a short, but I did also test that for good measure. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an incremental id for the ore veins is not a great idea when the order that they are loaded in can change. This changes it to save them with their string id which is very unlikely to change between versions.
If the veintypesLUT file is missing while the veins still need conversion it will purposefully prevent saving & loading since that file is still required for this to convert correctly. Without that file there's a chance that they'll be saved with a wrong string id.
Will prevent issues like GTNewHorizons/GT-New-Horizons-Modpack#18066 & GTNewHorizons/GT-New-Horizons-Modpack#18058 from occurring in the future.