Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neuter instability orb, prevent usage of .add() on WeightedList (use addAll() instead) #13

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Neuter instability orb, prevent usage of .add() on WeightedList (use addAll() instead) #13

merged 5 commits into from
Jan 14, 2023

Conversation

mitchej123
Copy link

@mitchej123 mitchej123 requested a review from a team January 14, 2023 18:51
D-Cysteine
D-Cysteine approved these changes Jan 14, 2023
View reviewed changes
Copy link

@D-Cysteine D-Cysteine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about HEE balance, but the code changes look good

@Connor-Colenso Connor-Colenso merged commit 27145a6 into master Jan 14, 2023
@Connor-Colenso Connor-Colenso deleted the yeet_instability_orb_and_speed_up_weighted_list_usage branch January 14, 2023 19:35
@LewisSaber
Copy link
Member

why not to make it toggable in config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D-Cysteine D-Cysteine D-Cysteine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getItem() was called 600 million times by HEE when it started GTNH
4 participants
@mitchej123 @LewisSaber @D-Cysteine @Connor-Colenso