Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Multiblock Lathe #3724

Merged
merged 10 commits into from
Jan 4, 2025
Merged

Simplified Multiblock Lathe #3724

merged 10 commits into from
Jan 4, 2025

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Dec 28, 2024

The new lathe multiblock had an excessivelly complex speed and parallel formulas, that depended on even hardcoded values not easily acessible in the tooltip. This PR simplifies it's logic and scaling along tiers and also tweaks it's values to more reasonable and easy numbers for new players, since this multiblock is HV/EV.

Closes GTNewHorizons/GT-New-Horizons-Modpack#18539

@HoleFish HoleFish added the Affects Balance Change affecting balance. Requires admin approval before merging. label Dec 28, 2024
@Dream-Master
Copy link
Member

The new lathe multiblock had an excessivelly complex speed and parallel formulas, that depended on even hardcoded values not easily acessible in the tooltip. This PR simplifies it's logic and scaling along tiers and also tweaks it's values to more reasonable and easy numbers for new players, since this multiblock is HV/EV.

Does it remove all the tired pipe casings? Can you add more infos or pictures how it was before and now ?

@Dream-Master Dream-Master requested a review from a team December 28, 2024 12:28
@serenibyss
Copy link
Member

@Dream-Master Pipe casing tiering is still present and similar to before, just with the numbers simplified accordingly for an EV-tier multiblock

@Nockyx Could you fix the compilation issues with this PR?

@Nockyx
Copy link
Contributor Author

Nockyx commented Dec 28, 2024

The Previous method scaled by using both the pipes and the voltage tier, but the bonuses provided by each pipe tier weren't consistent and could not be easily displayable on the tooltip.
image
This also resulted in a very complex scaling for such a trivial multiblock:
image

I simplified it to be more similar to other multiblocks that also scale with item pipe casings, such as the extractor.
image

The numbers make sure it is still better in endgame than an UMV PA would be.

@Ruling-0
Copy link
Contributor

(I hope this autolinks) this closes GTNewHorizons/GT-New-Horizons-Modpack#18539

@Nockyx
Copy link
Contributor Author

Nockyx commented Dec 29, 2024

Doesn't exactly close because it will need a questbook edit

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers and code look good, just one tiny tweak that I'll incorporate.

I'll leave this PR open for anyone else to comment on

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 30, 2024
@serenibyss serenibyss enabled auto-merge (squash) January 4, 2025 01:54
@serenibyss serenibyss merged commit ecefc5e into GTNewHorizons:master Jan 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Industrial Precision Lathe inaccurate tooltip
5 participants