Remove metadata casts to byte #3706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are incompatible with NEID and can cause problems with blocks whose metadata can go over 127.
RecursivePineapple
added
refactor
|
@RecursivePineapple Did you test this in full pack? There are probably changes needed in some other mods that add machines |
|
@serenibyss no I didn't, thanks for reminding me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are incompatible with NEID and cause problems with blocks whose metadata can go over 127.
This shouldn't have any side effects since nothing changed here relies on bit math.
I ran a quick sanity test on everything I touched to make sure I didn't break anything.
I didn't change some stuff related to ores & prospecting because I didn't want to create merge conflicts for my ore refactor PR, which already has those changes.
I'm sure I've missed something, but this should be most of the casts & byte params/returns. I used this regex to find these:
byte.*meta(case insensitive), then I fixed the syntax errors that resulted from the changes.