-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTESolarFactory #3703
base: master
Are you sure you want to change the base?
Add MTESolarFactory #3703
Conversation
# Conflicts: # src/main/java/gregtech/api/enums/GTValues.java
# Conflicts: # src/main/java/gregtech/loaders/preload/LoaderMetaTileEntities.java
src/main/java/gregtech/common/tileentities/machines/multi/MTESolarFactory.java
Outdated
Show resolved
Hide resolved
I think that the recipes of the solars should include the previous one as in the dire recipes, because if not there is no reason to have all the recipes, people are just going to use the last one |
If you need more space just add 3 more slots to the machine ( and could add as well 2 more for fluids) so if in the future there is some upgrade to solars there is space for recipes |
Have you brought this to the admins before making the PR? Please note the new procedures if you missed them https://discord.com/channels/181078474394566657/1243216765727539383/1317949621510733936 Edit: I have been told they are banned. well not sure what to do with this PR then. |
I remember there was such solar tower suggestion before pr . It’s been a while . The idea is nice but a bit to simple . Maybe add tiers like the pbc or so. |
src/main/java/gregtech/loaders/postload/recipes/SolarFactoryRecipes.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/multi/MTESolarFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/multi/MTESolarFactory.java
Outdated
Show resolved
Hide resolved
I've received a few suggestions and seen some feedback and will be implementing them soon enough. Marking this as draft until I feel its ready to merge again. |
Update/Continuation of #2281
Related pr for recipes: GTNewHorizons/NewHorizonsCoreMod#1120
NOTE: This multi is NOT meant to make Solar Panels as power generation better/more viable than they are now. It is only meant to improve user experience when automating them. I have adjusted recipe values to make them more expensive than they were before to counteract the Buffs that this multi provides. If the recipes haven't been nerfed enough, I will nerf them more.
Additional notes of importance:
This PR does not affect the balance of Compressed Solar Panels, as it cannot craft the 1V panels that Compressed Solar Panels need.
This PR does not remove the dire table solar panel recipes. If those get removed at some point, this multi should be downtiered to account for the big gap in tiering.
The multi is not a MuTE like the original pr said it would come back as. This is due to the MTE ban being lifted and that I believe the system isn't complete enough.
Basic idea of the multi:
The Solar Factory acts as a GT Replacement for the tiered Solar Panel recipes which are currently made in the Dire (Auto)Crafting Table. Since these Solar Panels are used heavily in some endgame recipes, the Dire Tables quickly become a bottleneck as well as a major annoyance since for the you have to manually set the recipe one item at a time if you want to automate them.
Currently the goal of the multi is not to make the Solar Panels easy to craft for power generation purposes.
Complaints I have addressed from the original pr (see above):
I have changed the structure to use Tungstensteel Casings. I think they look OK and are OK balance-wise, but I would like to hear if people think they should be changed to a different casing, or if I should make a whole new casing for the multi.
Below there is a screenshot of the structure in full, with the altered casing.
I have given it a new mechanic. Below there is a screenshot of the tooltip which explains it in detail, but the gist is that every solar has a minimum wafer tier in the recipe and using a higher tier wafer multiplies how many solar panels you get per recipe after parallels.
Speaking of parallels, There is now 13 Precise Unit Casings at the top and bottom of the structure for a total of 26. These work the same way as they do with the Precise Assembler, but with 1/4th the parallels and no Imprecise Unit Casing allowed since I felt T1 Precise was more in line with the tiering of the multi. The parallels are shown in the tooltip as well but are as follows:
MK-I = 8x, MK-II = 16x, MK-III = 32x, MK-IV = 64x
A couple examples:
LV panel recipe uses T2 (Phosphorus doped) wafers as a minimum. If you use T4 (Europium doped) wafers, the recipe will output 50% more LV panels. This means with 2x consumed inputs, you would get 3x panels.
ZPM panel recipe uses 8 T5 (Americium doped) wafers as a minimum. If you use 8 T4 wafers or 6 T5 wafers, the recipe wont run as wafer used is lower than the minimum tier for the former, and the wafer count is too low for the latter. If you wanted to use higher tier wafers for more output on this recipe, you would need to use either Photonically Prepared (T6) or Photonically Enhanced (T7).
I removed the custom background icon and the category icon is now normal. This one is more of a bug fix but there was a complaint about it.
Changes from the original that weren't complained about:
Please give feedback on if it should be downtiered lower. In the original pr dream gave ideas for the multi being as low as LV, and subsequently others have told me it should be MV/HV.
Theres probably some more changes that I dont remember right now. I'll edit this description if I think of more.
Structure and Tooltip:
For the tooltip, I felt there should be information on what wafers count and what tier they are, but a friend believes it would be bloat and what wafers the tooltip are talking about is obvious. Please give feedback on if its unclear or not.
Recipes:
The Solar Panel recipes are more expensive and tweaked versions of the current dire table recipes. Please give feedback on if they should be made more expensive to account for the buffs the multi gives.
The screenshot was taken before I made it use Tungstensteel casings so the controller has the steel casing texture. The data stick uses a 1V solar panel for the scanning recipe.