-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-block boilers accept empty containers again #3651
Conversation
ea76a69
to
9c9ec87
Compare
Why not allow partial fill in those cells with large capacities? I would imagine that since the larger cells like the aluminum one in your image have the capability to be partially filled that they would accept the minimum between the amount of steam in the boiler and the remaining space in the cell, and not be limited to pulling just the cell's full amount. The single bucker amount cells that can't be partially filled I would get having this behavior, but it seems a little weird for the cells that can be partially filled, like the aluminum or universal cell to follow that behavior. |
That's just how all GT tanks currently work, and if you think about it, it usually makes sense. For instance if I try to empty a super tank with 32000L cells, and keep emptying it as it fills up, I want the machine to fill them to full capacity, not waste my cell by only putting 1000L in it. That way they also neatly stack in the output slot. Not filled until there's enough fluidFilled cells stack because they're filled to capacity |
I will add that with other tanks you can manually click the fluid stack with your cell to do a partial fill. That feature could be added to the gauge of boilers if deemed necessary, but that would definitely be a separate PR. |
yea lets merge this and add a new pr if necessary. |
Co-authored-by: Martin Robertz <[email protected]> Co-authored-by: Maya <[email protected]> (cherry picked from commit 2355a65)
Co-authored-by: Martin Robertz <[email protected]> Co-authored-by: Maya <[email protected]>
Behavior accidentally broken in !2871..
You can now once again insert containers that could possibly get filled with steam, in addition to items that contain water.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#17966