Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-block boilers accept empty containers again #3651

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

YannickMG
Copy link
Contributor

Behavior accidentally broken in !2871..

You can now once again insert containers that could possibly get filled with steam, in addition to items that contain water.

smaller

Fixes GTNewHorizons/GT-New-Horizons-Modpack#17966

@YannickMG YannickMG added the bug fix Fix a bug. Please link it in the PR. label Dec 14, 2024
@YannickMG YannickMG requested review from a team and removed request for a team December 14, 2024 22:09
@YannickMG YannickMG marked this pull request as draft December 14, 2024 22:12
@YannickMG YannickMG force-pushed the sb-boilers-accept-empty-containers branch from ea76a69 to 9c9ec87 Compare December 14, 2024 22:21
@YannickMG YannickMG marked this pull request as ready for review December 14, 2024 22:23
@YannickMG YannickMG requested a review from a team December 14, 2024 22:24
@YannickMG
Copy link
Contributor Author

image

I had to draft for a moment because I initially misunderstood the container capacity check. Now it'll accept any container with capacity up to the boiler's capacity. Of course if it's exactly the same chances are it will never be filled because excess steam is vented off.

@ALongStringOfNumbers
Copy link
Contributor

Why not allow partial fill in those cells with large capacities? I would imagine that since the larger cells like the aluminum one in your image have the capability to be partially filled that they would accept the minimum between the amount of steam in the boiler and the remaining space in the cell, and not be limited to pulling just the cell's full amount.

The single bucker amount cells that can't be partially filled I would get having this behavior, but it seems a little weird for the cells that can be partially filled, like the aluminum or universal cell to follow that behavior.

@YannickMG
Copy link
Contributor Author

YannickMG commented Dec 14, 2024

Why not allow partial fill in those cells with large capacities? I would imagine that since the larger cells like the aluminum one in your image have the capability to be partially filled that they would accept the minimum between the amount of steam in the boiler and the remaining space in the cell, and not be limited to pulling just the cell's full amount.

The single bucker amount cells that can't be partially filled I would get having this behavior, but it seems a little weird for the cells that can be partially filled, like the aluminum or universal cell to follow that behavior.

That's just how all GT tanks currently work, and if you think about it, it usually makes sense.

For instance if I try to empty a super tank with 32000L cells, and keep emptying it as it fills up, I want the machine to fill them to full capacity, not waste my cell by only putting 1000L in it. That way they also neatly stack in the output slot.

Not filled until there's enough fluid

image

Filled cells stack because they're filled to capacity

image

@YannickMG
Copy link
Contributor Author

I will add that with other tanks you can manually click the fluid stack with your cell to do a partial fill. That feature could be added to the gauge of boilers if deemed necessary, but that would definitely be a separate PR.

@Dream-Master
Copy link
Member

yea lets merge this and add a new pr if necessary.

@serenibyss serenibyss enabled auto-merge (squash) December 15, 2024 15:47
@serenibyss serenibyss merged commit 2355a65 into master Dec 15, 2024
5 checks passed
@serenibyss serenibyss deleted the sb-boilers-accept-empty-containers branch December 15, 2024 15:53
Dream-Master pushed a commit that referenced this pull request Dec 15, 2024
Co-authored-by: Martin Robertz <[email protected]>
Co-authored-by: Maya <[email protected]>
(cherry picked from commit 2355a65)
Nockyx pushed a commit to Nockyx/GT5-Unofficial that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steam Solar Boiler can no longer fill cells
4 participants