getItem() was called 600 million times by HEE when it started GTNH

[wohaopa]

Your GTNH Discord Username

No response

Your Pack Version

2.2.8

Your Proposal

https://github.com/GTNewHorizons/Hardcore-Ender-Expansion/blob/dedd607537af03817f44ff94931f009b7be14903/src/main/java/chylex/hee/mechanics/orb/WeightedItemList.java#L8

The time and percentage are inaccurate.

Your Goal

This is just a brute force algorithm written to ensure the uniqueness of the list elements. I think there should be other ways to replace it.

Your Vision

Use efficient algorithms.

Final Checklist

• I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
• I understand this change request may not attract enough attention and thus not be implemented.
• I understand this change request may be rejected due to other community members think it's inappropriate.
• I believe this feature would make the pack better.

[boubou19]

ahah what a shitty way of doing stuff

[dahgul333]

Holy F...

[JustAlkaid]

Why not delete HEE instantly
I think we don't need this mod because there are little player need infinite The End dimension

[Dream-Master]

Why not delete HEE instantly I think we don't need this mod because there are little player need infinite The End dimension

We not remove Mods because of such code issues. We fix this issue.

[mitchej123]

Unless anyone has a strong argument in favor of keeping them, I'm going to neuter the instability orbs and remove this giant lag fest. @Connor-Colenso is on board ;)

[Shahelion]

So this is why the orbs just do nothing now?

[Rakdarian]

Can we actually fix this issue? it was a neat way post-nerf to get dungeon loot and was a fun minigame. Getting rid of it feels bad

[Dream-Master]

@Connor-Colenso can you check to make it work again ?

[Connor-Colenso]

The orbs were totally broken before so I wouldn't be for bringing them back. They could give any item in the game that had a "recipe" if I recall correctly, including corrupted items with invalid NBT and items that totally broke intended progression. That and they were insanely laggy.

So, I don't think they will see a return.

[boubou19]

If it makes a return, that would be with a predefined looting table, but that would remove a lot of incentive to go for this item, as it was known to be incredibly powerful, provided you didn't corrupt your world with it. And i don't think this item missing from HEE in the pack is a great loss.

[Shahelion]

What about having it pull from specified loot tables? There could be a section of the config to allow users to specify which loot tables it can pull from (stronghold library, standard dungeon, nether roof, village apothecary, etc). This allows specifying what items are accessible, and prevents invalid loot or unwanted progression breaks.

…

________________________________ From: Connor-Colenso ***@***.***> Sent: November 19, 2024 4:08 AM To: GTNewHorizons/GT-New-Horizons-Modpack ***@***.***> Cc: Colin ***@***.***>; Comment ***@***.***> Subject: Re: [GTNewHorizons/GT-New-Horizons-Modpack] getItem() was called 600 million times by HEE when it started GTNH (Issue #12254) The orbs were totally broken before so I wouldn't be for bringing them back. They could give any item in the game that had a "recipe" if I recall correctly, including corrupted items with invalid NBT and items that totally broke intended progression. That and they were insanely laggy. So, I don't think they will see a return. — Reply to this email directly, view it on GitHub<#12254 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUY3H2VPWMQONAXGU4ZGZ32BMS2RAVCNFSM6AAAAABOW73JBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVGQ2TQNRUGU>. You are receiving this because you commented.Message ID: ***@***.***>

[Rakdarian]

that was the previous implementation prior to this change. You could only get stronghold/dungeon loot stuff. It was a part of my playthrough on LewisSaber's server