Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: option to hide "stored" items in ae2 crafting plan #620

Conversation

lordIcocain
Copy link

@lordIcocain lordIcocain commented Dec 13, 2024

@MCTBL
Copy link
Member

MCTBL commented Dec 14, 2024

should we add some way to show now is hidding or not hidding?

…u_gui_button' into hide_stored_items_in_crafting_cpu_gui_button
@lordIcocain
Copy link
Author

@MCTBL

idn.mp4

@Wo0kiee
Copy link

Wo0kiee commented Dec 14, 2024

idn.mp4

Maybe it would be a good idea to move the button to the left so they are in the same place.
And make it a texture, so people can change it however they want

@lordIcocain
Copy link
Author

image
image

@Dream-Master Dream-Master requested a review from a team December 14, 2024 15:15
@MCTBL
Copy link
Member

MCTBL commented Dec 15, 2024

would u think this is better?

show hide
image image

or change the hide ico to a grey eye?

@lordIcocain
Copy link
Author

Idk how make reference to dragon ball in button texture, so i don't care how it will look :kekw:

@bluhbipo
Copy link
Member

bluhbipo commented Dec 15, 2024

finally got around to testing this. the code is currently non functional as it hides some items being crafted but not others
image
image
yes, i double checked with my handy mouse scroll wheel

EDIT: also, changes are not saved when exiting the menu and reentering

@lordIcocain
Copy link
Author

@bluhbipo Should work rn and save able. I also made "terminal style" save able, i think it was bug.

@bluhbipo
Copy link
Member

feature is fully working!

@chochem chochem added the new feature Add something new. Please explain in detail how it works. label Dec 16, 2024
@serenibyss
Copy link
Member

serenibyss commented Dec 22, 2024

Found a minor problem, reproduction case:

  1. Start a craft with enough steps and/or stored items to need to scroll to see it all
  2. Let it get to a point where there is not enough things to need to scroll when stored items are hidden
  3. Hide stored items
  4. Close and reopen the UI
  5. Show stored items

you can no longer scroll to see everything

@lordIcocain
Copy link
Author

scroll should updating correct rn

@serenibyss serenibyss merged commit 0f57617 into GTNewHorizons:master Dec 23, 2024
1 check passed
@lordIcocain lordIcocain deleted the hide_stored_items_in_crafting_cpu_gui_button branch December 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to hide "stored" items in ae2 crafting plan
7 participants