Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New texture and added inf lava cell #250

Closed
wants to merge 1 commit into from
Closed

New texture and added inf lava cell #250

wants to merge 1 commit into from

Conversation

EnderProyects
Copy link

Added inf lava cell and 2 new textures, one for the water one, and other for the lava one, here I need help in the alocated code to call for the new textures instead of the old one
Part of the code from: #189
image

Need to add a recipe in coremod for the lava one, magic gated of course
image

@EnderProyects
New texture and added inf lava cell
17f432b 
Added inf lava cell and 2 nre textures, one for the water one, and other for the lava one, here I need help in the alocated code to call for the new textures instead of the old one
@EnderProyects
Copy link
Author

The new textures are part of the pr, but can also send them here so they are eassy to see
fluid_storage water
fluid_storage lava

@chochem chochem added affects balance requires admin approval new feature Add something new. Please explain in detail how it works. labels Dec 16, 2024
@EnderProyects EnderProyects mentioned this pull request Dec 16, 2024
Closed
serenibyss
serenibyss requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lava cell is not something we want in the pack, please remove it from this PR and make this just the water cell texture (nice texture on that btw)

@EnderProyects
Copy link
Author

Lava cell is not something we want in the pack, please remove it from this PR and make this just the water cell texture (nice texture on that btw)

Inf lava is as simple as ataching a storage bus to a container that pulls from a Everburn Urn ( Ev gated) I dont see why it should be a problem to have a cell later in the game +UV since tantalite is not a problem at that stage, and I dont thing somebody will make an array of Vulcan geothermal Engines just to power its base

@LazyFleshWasTaken
Copy link

Lava cell is not something we want in the pack, please remove it from this PR and make this just the water cell texture (nice texture on that btw)

Inf lava is as simple as ataching a storage bus to a container that pulls from a Everburn Urn ( Ev gated) I dont see why it should be a problem to have a cell later in the game +UV since tantalite is not a problem at that stage, and I dont thing somebody will make an array of Vulcan geothermal Engines just to power its base

The problem is the near-infinite throughput of such a cell. It can be abused for limitless power.

@EnderProyects
Copy link
Author

Lava cell is not something we want in the pack, please remove it from this PR and make this just the water cell texture (nice texture on that btw)

P.d this pr can be merged since the default recipe is not loaded in the pack, so at least the cell is for creative mode use or future ussage

@serenibyss
Copy link
Member

Creative fluid cell exists for that purpose

@EnderProyects
Copy link
Author

Closing this pr and creating a new one just for the texture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss requested changes

Assignees
No one assigned
Labels
affects balance requires admin approval new feature Add something new. Please explain in detail how it works.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EnderProyects @LazyFleshWasTaken @serenibyss @chochem