Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed essentia level maintaining #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RecursivePineapple
Copy link

@RecursivePineapple RecursivePineapple commented Nov 19, 2024

You could previously level maintain the thaumic energistics fake essentia item, but this wouldn't work properly due to the continuous buildup of the fake items. It would work initially, but once you added or removed any essentia, it would not make more.

To fix this, this commit checks if the maintained item is an essentia stack and does two things.

First, it will convert NEI addon aspects to thaumic energistics. This is because it's very difficult to get the thaumic energistics item (to configure maintainers).
Side note: I tried to add some logic to AE's SlotFake that converts addon aspects to thaumic energistics aspects, but it broke level maintainers. It added very little, so I scrapped that idea and just made level maintainers treat the two fake essentia items the same.

Second, it will check the essentia cache to get the stack size instead of the item cache. Since essentia exists in its own cache, you cannot check the item cache to find its stored quantity. It would also be possible to check the fluid cache, but there wasn't much point since it was trivial to access the essentia cache instead.
The thaumic energistics item aspect is still needed to craft the essentia, so we only need to get the essentia stack size.

You could previously level maintain the thaumic energistics fake
essentia item, but this wouldn't work properly due to the continuous
buildup of the fake items. It would work initially, but once you added
or removed any essentia, it would not make more.

To fix this, this commit checks if the maintained item is an essentia
stack and does two things.

First, it will convert NEI addon aspects to thaumic energistics. This
is because it's very difficult to get the thaumic energistics item (to
configure maintainers).
I tried to add some logic to AE's SlotFake that converts addon aspects
to thaumic energistics aspects, but it broke level maintainers. It added
very little, so I removed that.

Second, it will check the essentia cache to get the stack size instead of
the item cache.
@RecursivePineapple RecursivePineapple added bug Something isn't working enhancement New feature or request labels Nov 19, 2024
@RecursivePineapple RecursivePineapple requested a review from a team November 19, 2024 19:26
@RecursivePineapple
Copy link
Author

2024-11-19_14 11 20
2024-11-19_14 11 26
2024-11-19_14 11 27
2024-11-19_14 11 29
2024-11-19_14 11 49
2024-11-19_14 11 55
2024-11-19_14 16 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant