Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andy/220 profile fix settings #223

Merged
merged 7 commits into from
Nov 3, 2024
Merged

Conversation

andyvo2004
Copy link
Contributor

@andyvo2004 andyvo2004 commented Oct 31, 2024

220

Issue Number(s): #220 .

What does this PR change and why?

  • fixed ontimecomplete for reading and writing, will continue counting until player finishes current question
  • fixed truncation error, rounded stats for summaries
  • trivia asks if right or wrong and changes stats accordingly
  • created profile screen with verification for inputs and api call (untested)
  • changed how profileicon and homeicon are called in order to change color easier

Checklist

  • Profile page added
  • Trivia page added

Critical Changes / Notes

  • no area code field in api, so changing it in profile only changes it locally
  • no field to change secondary contact information
  • used patient signup endpoint, so there is no field to change associated chapter. changing it in profile only changes it locally
  • keyboard can cover the input fields
  • no exit button from keypad, so after entering phone number, the user will need to click to a different field and return from there

Related PRs

Testing

Test to see if game continues counting even after time runs out for reading and writing. Check that values are truncated by putting long decimal numbers for time. Check to see if trivia stats are changed according to if the user got the question right or wrong. Ensure that invalid inputs are not allowed for profile screen, and test api to ensure data is inputted properly.

Copy link

github-actions bot commented Oct 31, 2024

🚀 Expo preview is ready!

  • Project → brain-exercise
  • Platforms → android, ios
  • Scheme → myscheme
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@johannesq23 johannesq23 merged commit 7d48fcb into develop Nov 3, 2024
2 checks passed
@johannesq23 johannesq23 deleted the andy/220-profile-fix-settings branch November 3, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants