Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shivani/217-Reading-Writing-Settings-page-updates #219

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

ShivaniVora
Copy link
Contributor

@ShivaniVora ShivaniVora commented Oct 12, 2024

Redesigning the reading, writing, and settings pages within the app. Fixing serializability bug.

Issue Number(s): #217

pulled from andy's PR
added packages to update expo, add tunneling, and font family

Checklist

  • Reading Pages Updated
  • Writing Pages Updated
  • Fixed Serializability Bug
  • Settings Page Updated (Figma missing for Terms and Conditions [not functional], Privacy Policy [not functional], and Streak Length [don't understand functionality])

Bugs:

  • Font size slider will not move according to the new font size (should be pulling from the current font size)
  • Font size only updates after closing settings (maybe not across the app but within settings changes are visible)
  • There was no pre existing slider/back-end logic for a slider in the Sound settings, only added toggle for Sound Effect and Voice Over
  • Settings changes do not hold over do to local storage issues, everything should be getting set properly but they will not save if pages are changed.
  • Styling cannot be applied to "Confirm Time" button on TimePicker Modal

Copy link

github-actions bot commented Oct 12, 2024

🚀 Expo preview is ready!

  • Project → brain-exercise
  • Platforms → android, ios
  • Scheme → myscheme
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@ShivaniVora ShivaniVora marked this pull request as ready for review October 13, 2024 06:23
Copy link
Contributor

@johannesq23 johannesq23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@johannesq23 johannesq23 merged commit a903777 into develop Oct 22, 2024
2 checks passed
@johannesq23 johannesq23 deleted the shivani/217-reading-writing-settings-page-updates branch October 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants