Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nik/210 link up full completion summary #212

Merged
merged 8 commits into from
Sep 15, 2024

Conversation

nikvijay07
Copy link
Contributor

@nikvijay07 nikvijay07 commented Sep 13, 2024

[##] PR Title

Issue Number(s): #210

What does this PR change and why?

  • Completion Summary Page
  • Created new components for each subject view
  • Added Function to properly display time
pr.mov

Checklist

  • Button redirects to a new page
  • Completion Summary page shows each component, math, reading, writing, trivia.
  • Completion Summary page shows grayed out component if it has not been finished yet.

Critical Changes / Notes

  • None

Related PRs

  • None

Testing

  • None
    Enumerate steps to test the functionality of your ticket. This should include edge cases and testing of error handling, if applicable.

Copy link

github-actions bot commented Sep 13, 2024

🚀 Expo preview is ready!

  • Project → brain-exercise
  • Platforms → android, ios
  • Scheme → myscheme
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

</Text>
</View>

{questionsCompleted > 0 ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ended up making this a nested ternary so it is kind of hard to read.

@nikvijay07 nikvijay07 linked an issue Sep 13, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@johannesq23 johannesq23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. well done

@johannesq23 johannesq23 merged commit 931628a into develop Sep 15, 2024
2 checks passed
@johannesq23 johannesq23 deleted the nik/210-link-up-full-completion-summary branch October 27, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fullstack] Link up Full Completion Summary Button
2 participants