Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/CalendarComponent #327

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

charliejlin
Copy link
Collaborator

…finished (filters are not implemented)

  • Upcoming Events is only showing the first (displayNumber) events currently
  • Code to filter out events that are past current date is in but not implemented
  • All "Custom Recurrence" filters not implemented (form wise yes but not upcoming events component)

@charliejlin charliejlin linked an issue Nov 2, 2024 that may be closed by this pull request
@charliejlin charliejlin changed the title completed calendar form, upcoming events component is not completely … feature/CalendarComponent Nov 2, 2024
@charliejlin
Copy link
Collaborator Author

HOW UPCOMING EVENTS ARE DISPLAYED

Sorting and Display Count:

  • Events are sorted by start date, from the closest to the farthest.
  • A specified number of events will be displayed.

Filtering Logic:

  • Past Events: If the current date is past an event’s toDate, it will be filtered out before rendering.
  • Non-Custom Events: These will be displayed as long as they are not expired (toDate is after the current date).
  • Custom Events: Additional filtering is applied based on weekday selection and other settings.

Custom Events Filtering by Weekday:

  • Custom events are shown only on selected weekdays. For example, if today is Monday, an event will only be displayed if "Monday" is among its selected weekdays.

Selective Showing Settings:

  • end == ON:

    • The selective showing feature will end on a defined date.
    • After this date, the event will be shown regardless of the weekday selection, as long as it isn’t expired.
    • The values for selective showing will remain set, allowing the user to re-enable it by adjusting the end date.
  • after == ON:

    • Selective showing is limited by a maximum occurrence count.
    • For each selected weekday, the system counts how many times it has occurred since the event’s start date.
    • If the occurrence count exceeds the maximum, selective showing is disabled, similar to the end setting.

@charliejlin
Copy link
Collaborator Author

charliejlin commented Nov 4, 2024

Screenshot 2024-11-03 at 11 02 30 PM also the border bottom for the last tile is showing because of a internal padding set by the collapsible. I'm not sure how to remove without changing that padding. May have to adjust padding/margin top for the individual events too; didn't want to since the internal padding already adds to the first event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar Component
1 participant