-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
931 Connection Security for Network Component #938
Open
kyhu65867
wants to merge
3
commits into
GSA:develop
Choose a base branch
from
kyhu65867:931-connection-security
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes to get the tests passing so we can open this for review 😄
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
14 tasks
Gabeblis
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple suggestions for improvement.
… work because I am still figuring out oscal syntax
kyhu65867
force-pushed
the
931-connection-security
branch
from
November 27, 2024 17:15
6625c35
to
9bcc47b
Compare
wandmagic
approved these changes
Nov 27, 2024
DimitriZhurkin
requested changes
Nov 27, 2024
DimitriZhurkin
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… work because I am still figuring out oscal syntax
Committer Notes
This is a draft. I may need some help tomorrow figuring out if there is a connection security property or if it should be "interconnection security"
Addresses issue #931
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.