Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation point constraint #936

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

implementation point constraint #936

wants to merge 22 commits into from

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 25, 2024 •
edited by Gabeblis
Loading

Committer Notes

add implementation point constraint

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner November 25, 2024 16:55
kyhu65867
kyhu65867 reviewed Nov 25, 2024
View reviewed changes
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think of this feedback-- mostly to do with the failing unit test. I'm going to comment for now because I'm not sure if it is blocking

src/validations/constraints/content/ssp-network-component-has-implementation-point-INVALID.xml Show resolved Hide resolved
Gabeblis and others added 3 commits November 25, 2024 15:10
@Gabeblis @wandmagic @aj-stein-gsa
Add saas-has-leveraged-authorization Constraint (GSA#919)
cfb3e1d 
* Add saas-has-leveraged-authorization constraint and tests

* add is-saas var

* Update src/validations/constraints/fedramp-external-constraints.xml


---------

Co-authored-by: wandmagic <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
@wandmagic
improve constraint
09e0801
@Gabeblis @aj-stein-gsa @DimitriZhurkin
Add user-authentication Allowed Values (GSA#921)
edc5a7a 
* Add user authentication allowed values

* add help-url

* Fix constraint target and test data files

* Correct test data

* change 'http' to 'https'

---------

Co-authored-by:   A.J. Stein <[email protected]>
Co-authored-by:   Dimitri Zhurkin <[email protected]>
wandmagic and others added 2 commits November 26, 2024 08:23
@wandmagic
add extra fail content
af21682
@Gabeblis
Add Leveraged Authorization Entry Constraints (GSA#918)
57fd879 
* Add leveraged authorization entry constraints and tests

* remove user-authentication check
@Gabeblis Gabeblis linked an issue Nov 26, 2024 that may be closed by this pull request
Check that interconnected services' components in a SSP have an implementation points #928
Open
14 tasks
Gabeblis
Gabeblis previously approved these changes Nov 26, 2024
View reviewed changes
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 26, 2024
View reviewed changes
Gabeblis
Gabeblis previously approved these changes Nov 26, 2024
View reviewed changes
wandmagic and others added 5 commits November 26, 2024 15:14
@wandmagic
update oscal cli version
ae76fad
@wandmagic
Update fedramp_extensions_steps.ts
0bb7f93
@wandmagic
keep lint step
6163b66
@DimitriZhurkin
Add external-system-nature-of-agreement (GSA#929)
49f152a 
* Add external-system-nature-of-agreement

* Update help-url

* Modified Metapath as per GSA#907
@Gabeblis @wandmagic
Add component-has-authentication-method Constraint (GSA#927)
80eb99c 
* add constraint and tests

* trim test data

* add constraint and tests

* trim test data

* fix test data

* change 'http' to 'https'

* Remove extra word

* Edit message

---------

Co-authored-by: ~ . ~ <[email protected]>
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 27, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyhu65867 kyhu65867 kyhu65867 left review comments

@Gabeblis Gabeblis Gabeblis left review comments

@DimitriZhurkin DimitriZhurkin DimitriZhurkin left review comments

@Rene2mt Rene2mt Awaiting requested review from Rene2mt

Requested changes must be addressed to merge this pull request.

Assignees

@wandmagic wandmagic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that interconnected services' components in a SSP have an implementation points
5 participants
@wandmagic @Rene2mt @DimitriZhurkin @Gabeblis @kyhu65867