Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 800-60 Revision 2 Volume 1 information types with names and categories #917

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 19, 2024

Committer Notes

improve information-types constraint

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner November 19, 2024 19:41
@wandmagic
Copy link
Collaborator Author

addresses #890

Copy link

@DimitriZhurkin DimitriZhurkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wandmagic,

For the sake of consistency, in @value attributes, do you want to replace single quotes with double quotes?

@aj-stein-gsa aj-stein-gsa changed the title Update fedramp-external-allowed-values.xml Update 800-60 Revision 2 Volume 1 information types with names and categories Nov 19, 2024
@wandmagic
Copy link
Collaborator Author

@wandmagic,

For the sake of consistency, in @value attributes, do you want to replace single quotes with double quotes?

fixed

DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 19, 2024
Copy link

@DimitriZhurkin DimitriZhurkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super job!

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry messed up scope of last review suggestion.

aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 19, 2024
@aj-stein-gsa aj-stein-gsa requested review from DimitriZhurkin and a team November 19, 2024 22:07
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 19, 2024
Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aj-stein-gsa were we looking to remove all instances of &#x2F here? Just something that I caught. If not, go ahead and ignore this feedback.

Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@wandmagic wandmagic merged commit a79a5fb into GSA:develop Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more details and organization to 800-60 Revision 2 Volume 1 information type allowed-values constraint
5 participants