-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 800-60 Revision 2 Volume 1 information types with names and categories #917
Conversation
addresses #890 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of consistency, in @value
attributes, do you want to replace single quotes with double quotes?
ae52995
to
aff491e
Compare
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry messed up scope of last review suggestion.
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: A.J. Stein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aj-stein-gsa were we looking to remove all instances of /
here? Just something that I caught. If not, go ahead and ignore this feedback.
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabeblis <[email protected]>
e2cb28c
Co-authored-by: Gabeblis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Committer Notes
improve information-types constraint
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.