Include uaa username in bot user report

GSA-TTS · Nov 18, 2024 · a2f0bcb · a2f0bcb
1 parent 2972f3d
commit a2f0bcb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/auditree/templates/reports/cf/user-roles.md.tmpl b/auditree/templates/reports/cf/user-roles.md.tmpl
@@ -6,9 +6,10 @@ The following users have access to our cloud.gov infrastructure.
 
 {% for section_heading, user_guids in all_successes.items() -%}
 ## {{ section_heading }}
-{% for guid in user_guids: %}
+| User Name | Roles |
+| --------- | ----- |
+{% for guid in user_guids: -%}
 {% set user = test.users[guid] -%}
-* **User**: {{ user["user_name"] }}<br />
-  **Roles**: {{ user["roles"] | join(', ') }}
+| {{ user["user_name"] }} | {{ user["roles"] | join('<br/>') | safe }} |
 {% endfor %}
 {% endfor %}
diff --git a/auditree/utils/cf_roles.py b/auditree/utils/cf_roles.py
@@ -48,9 +48,10 @@ def __init__(self, entity):
   @property
   def username(self):
     if self._is_service_account:
-      return client.v3.service_credential_bindings.get(
+      service_name = client.v3.service_credential_bindings.get(
         self._username, include="service_instance"
       ).service_instance()["name"]
+      return f"{service_name} ({self._username})"
     else:
       return self._username