Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for symmetry factor feature in GRChombo #26

Merged
merged 13 commits into from
Nov 5, 2024

Commits on Aug 31, 2024

  1. Corrections for symmetry factor feature in GRChombo

    Corrected the params files and any uses of AMRReductions in
    both of the Examples, to account for the integral symmetry factor
    feature in GRChombo (see GRChombo Issue No. 197). Specifically:
    
    1. Added the symmetry_correction flag to the params files
    (under the Boundary Condition parameters)
    2. Provided the chombo parameter storing the symmetry factor
    to every instance of the norm and sum AMRReductions functions,
    in the specificPostTimeStep() function for each example.
    
    Note that the symmetry factor is calculated entirely in the
    ChomboParameters.h file of the main GRChombo repo.
    the-florist committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    159c20e View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Corrections for symmetry factor feature in GRChombo

    Added the symmetry factor flag to params for both examples,
    enabling calls to AMRReductions the ability to correct for
    symmetry factor associated with reflective boundary conditions
    (see Issue 197).
    the-florist committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    07d6ba8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c647ad3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e39270 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    cf16ed4 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    e1c8afb View commit details
    Browse the repository at this point in the history
  2. Small changes in tests

    dinatraykova committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ac53bf2 View commit details
    Browse the repository at this point in the history
  3. Revert "Small changes in tests"

    This reverts commit ac53bf2.
    dinatraykova committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    1e3bfa9 View commit details
    Browse the repository at this point in the history
  4. Small changes to tests

    dinatraykova committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    259e5df View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a94235 View commit details
    Browse the repository at this point in the history
  6. Remove mpi matrix

    dinatraykova committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c40b85b View commit details
    Browse the repository at this point in the history
  7. typo fix

    dinatraykova committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6fe2ef3 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    b77a8df View commit details
    Browse the repository at this point in the history