-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections for symmetry factor feature in GRChombo #26
Merged
Commits on Aug 31, 2024
-
Corrections for symmetry factor feature in GRChombo
Corrected the params files and any uses of AMRReductions in both of the Examples, to account for the integral symmetry factor feature in GRChombo (see GRChombo Issue No. 197). Specifically: 1. Added the symmetry_correction flag to the params files (under the Boundary Condition parameters) 2. Provided the chombo parameter storing the symmetry factor to every instance of the norm and sum AMRReductions functions, in the specificPostTimeStep() function for each example. Note that the symmetry factor is calculated entirely in the ChomboParameters.h file of the main GRChombo repo.
Configuration menu - View commit details
-
Copy full SHA for 159c20e - Browse repository at this point
Copy the full SHA 159c20eView commit details
Commits on Sep 8, 2024
-
Corrections for symmetry factor feature in GRChombo
Added the symmetry factor flag to params for both examples, enabling calls to AMRReductions the ability to correct for symmetry factor associated with reflective boundary conditions (see Issue 197).
Configuration menu - View commit details
-
Copy full SHA for 07d6ba8 - Browse repository at this point
Copy the full SHA 07d6ba8View commit details -
Merge branch 'bugfix/integral-symmetry-factor' of https://github.com/…
…GRTLCollaboration/GRDzhadzha into bugfix/integral-symmetry-factor
Configuration menu - View commit details
-
Copy full SHA for c647ad3 - Browse repository at this point
Copy the full SHA c647ad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e39270 - Browse repository at this point
Copy the full SHA 2e39270View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf16ed4 - Browse repository at this point
Copy the full SHA cf16ed4View commit details
Commits on Nov 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1c8afb - Browse repository at this point
Copy the full SHA e1c8afbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac53bf2 - Browse repository at this point
Copy the full SHA ac53bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e3bfa9 - Browse repository at this point
Copy the full SHA 1e3bfa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 259e5df - Browse repository at this point
Copy the full SHA 259e5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a94235 - Browse repository at this point
Copy the full SHA 6a94235View commit details -
Configuration menu - View commit details
-
Copy full SHA for c40b85b - Browse repository at this point
Copy the full SHA c40b85bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fe2ef3 - Browse repository at this point
Copy the full SHA 6fe2ef3View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b77a8df - Browse repository at this point
Copy the full SHA b77a8dfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.