Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mem release #646

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Mem release #646

wants to merge 15 commits into from

Conversation

dmitrii-z
Copy link
Contributor

@ARozghon
Copy link

ARozghon commented Jul 6, 2023

looks promising, @V-Gorash please, review

@bsavery bsavery self-requested a review July 8, 2023 01:28
@bsavery
Copy link
Contributor

bsavery commented Jul 8, 2023

QA approved?

Vsevolod1983
Vsevolod1983 suggested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Vsevolod1983 Vsevolod1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please

  1. Remove adding new files for all plugins except Houdini (i.e resourceWatcher.cpp and h)
  2. Put all function calls and include directives under houdini only macros

@ARozghon
Copy link

as I understand, is this PR on draft?

@dmitrii-z dmitrii-z marked this pull request as draft September 13, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGorash VGorash VGorash approved these changes

@Vsevolod1983 Vsevolod1983 Vsevolod1983 approved these changes

@bsavery bsavery Awaiting requested review from bsavery

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitrii-z @ARozghon @bsavery @Vsevolod1983 @VGorash