WIP::Speedup tabix histogram #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@cmdcolin This works (definitely gives different results, but they are what I want for this). I'm trying to test it on large data within Apollo to see if it actually makes any difference. |
|
For 28Mbps . . . performance is almost identical. |
|
There are a few other issues, not really related to this, that I think are more performant worrying, mostly that they needs to be asynchronous calls to count things (instead of bring back anything).
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting a pull request
Please base your pull request based on the "dev" branch of JBrowse
The default branch is "master" but this contains the last stable release, and new pull requests should be based off of "dev"
Then set the base branch to "dev" on GitHub also