Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAM parsing optimization #993

Merged
merged 13 commits into from
Jun 9, 2020
Merged

BAM parsing optimization #993

merged 13 commits into from
Jun 9, 2020

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 9, 2020

This addresses #969

The performance is about 3x as fast, measured here

https://jsperf.com/md-parsing

This does so by adjusting CIGAR parsing and MD usage of the CIGAR

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #993 into master will increase coverage by 0.03%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   58.42%   58.45%   +0.03%     
==========================================
  Files         386      387       +1     
  Lines       15849    15884      +35     
  Branches     3577     3581       +4     
==========================================
+ Hits         9259     9285      +26     
- Misses       6294     6304      +10     
+ Partials      296      295       -1     
Impacted Files Coverage Δ
...es/alignments/src/PileupRenderer/PileupRenderer.ts 89.72% <ø> (ø)
packages/alignments/src/PileupRenderer/sortUtil.ts 41.46% <ø> (ø)
...lignments/src/BamAdapter/BamSlightlyLazyFeature.ts 64.70% <62.50%> (-11.32%) ⬇️
...ckages/alignments/src/BamAdapter/MismatchParser.ts 86.60% <86.60%> (ø)
packages/core/util/index.ts 81.59% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb60ed...421f973. Read the comment docs.

@rbuels rbuels merged commit 14502fd into master Jun 9, 2020
@rbuels
Copy link
Contributor

rbuels commented Jun 9, 2020

niiice

@rbuels rbuels deleted the bam_optimization branch June 9, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants