Improve speed for laying out features for embedded/mainthreadrpc scenarios #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
force-pushed
the
revert_to_regular_map_layout
branch
from
8702e56 to
a20deba
Compare
Codecov Report
@@ Coverage Diff @@
## main #2097 +/- ##
==========================================
+ Coverage 61.45% 61.93% +0.47%
==========================================
Files 480 476 -4
Lines 22981 22783 -198
Branches 5391 5345 -46
==========================================
- Hits 14124 14111 -13
+ Misses 8574 8390 -184
+ Partials 283 282 -1
Continue to review full report at Codecov.
|
garrettjstevens
approved these changes
Jul 1, 2021
cmdcolin
added a commit
that referenced
this pull request
Jul 5, 2021
* Drive mouseovers using layout data structure * Intermediate * Fixup breakpoint split view * Fix unit tests * Fix up some lint and tsc * Standardize getById to return recttuple for both layouts * Remove unused breakpoint split viewer from linear-comparative-view
cmdcolin
added
enhancement
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the rectangles data structure for granularrectlayout back to a normal map instead of an observable map. The layout is queried directly for nodes at a given position, and precompute layout uses rbush to do this (previously precompute layout didn't have any function to do this)
Fixes #2038