-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc bug fixes + enable LTO support #19
base: master
Are you sure you want to change the base?
Conversation
60a714e
to
d44f275
Compare
e79e065
to
fcd97ed
Compare
…ay not be supported (e.g. musl)
@GJDuck hi, I git cloned the forked repo from @ddcc and tested this PR on my laptop Linux Mint 20.3 (which is based on Ubuntu 20.04 package base). This PR works on my linux machine, ie. I can compile LowFat and use it successfully. Like the issue #20 mentioned, I also could not get LowFat to compile on my Mint 20.3, but this PR can compile. EnvironmentOS: Linux Mint 20.3 (Una) Software TestedI happen to keep some logs of software built with LowFat before I upgraded my Mint distro, and I get to compare the before-and-after logs. Here are some software I compared and found no difference in the output:
and a couple of simple toy examples from coursework Additional DependenciesI found that I had to install
Otherwise the build shell script works. |
@FeynmanDNA thanks for testing it. I also tried on an old 16.04 system and it seems to build. Regarding 8925330, there is a reason why the preinit array is used. Although it has been a few years so I forget the exact reason. Likely some cherry picking will be required. |
Just an update on this. I attempted to selectively merge specific patches, but the resulting build would fail the tests due to a misaligned stack. For me, the stack is misaligned regardless on whether 92fa1e0 is used or not, so I am not sure what the problem is. I will get back to this one day... |
Tested on Ubuntu 20.04