Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UNICEF topics #833

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Adding UNICEF topics #833

merged 6 commits into from
Oct 10, 2024

Conversation

hn437
Copy link
Contributor

@hn437 hn437 commented Oct 9, 2024

Description

This PR adds the topics required for the UNICEF Project as described in issue #832 and implements the new project. All required updates as assignments of topics to the indicators or updating the relevant tests are done as well.

Corresponding issue

Closes #832

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@hn437 hn437 self-assigned this Oct 9, 2024
@hn437 hn437 requested review from mmerdes and Gigaszi October 9, 2024 14:37
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked by @Gigaszi and myself: metadata config looks consistent; tested with frontend as well.

@mmerdes mmerdes merged commit 2852b4d into main Oct 10, 2024
2 checks passed
@mmerdes mmerdes deleted the unicef-topics branch October 10, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNICEF Topics
2 participants