Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(building-comparison): add Microsoft Building Footprints dataset #768

Merged
merged 33 commits into from
Feb 3, 2024

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jan 29, 2024

Description

This PR adds generic support of multiple datasets to the building comparison indicator.

Corresponding issue

Closes #761
Closes #769
Closes #770

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Check geodatabase tests (disable skip mark at top of the file to run all tests)
  • Rename SQL file and check for files not in use
  • Fix test_definitions.py
  • Add issue for complexity reduction of calculate func

@matthiasschaub matthiasschaub marked this pull request as draft January 29, 2024 09:17
@matthiasschaub matthiasschaub marked this pull request as ready for review January 31, 2024 10:52
@matthiasschaub matthiasschaub changed the title Building comparison multiple datasets refactor feat(building-comparison): add Microsoft Building Footprints dataset Feb 3, 2024
@matthiasschaub matthiasschaub merged commit 8335cfb into main Feb 3, 2024
2 checks passed
@matthiasschaub matthiasschaub deleted the building-comparison-multiple-datasets-refactor branch February 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants