Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(indicators): separate templates from metadata and merge all metadata files #673

Merged
merged 4 commits into from
Sep 27, 2024
Merged

refactor(indicators): separate templates from metadata and merge all metadata files #673

merged 4 commits into from
Sep 27, 2024

Conversation

Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Aug 10, 2023 •
edited by matthiasschaub
Loading

Description

  • refactor(indicators): separate templates from metadata
    • separate indicators text templates for label and result description from metadata.
  • refactor(indicators): merge all metadata files
    • merge all indicator metadata files into one similar to metadata files of topics and projects

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@Gigaszi Gigaszi marked this pull request as ready for review August 22, 2023 13:07
@matthiasschaub matthiasschaub self-assigned this Aug 28, 2024
@matthiasschaub
refactor(indicators): separate templates from metadata
11d6efb 
separate indicators text templates for label and result description from
metadata.
@matthiasschaub matthiasschaub marked this pull request as draft September 26, 2024 02:44
@matthiasschaub matthiasschaub marked this pull request as ready for review September 26, 2024 03:29
@matthiasschaub matthiasschaub changed the title feat: add get_template function refactor(indicators): separate templates from metadata and merge all indicators metadata files Sep 26, 2024
@matthiasschaub
refactor(indicators): merge all metadata files
dc9873a 
merge all indicator metadata files into one similar to metadata files of
topics and projects
@matthiasschaub matthiasschaub changed the title refactor(indicators): separate templates from metadata and merge all indicators metadata files refactor(indicators): separate templates from metadata and merge all metadata files Sep 26, 2024
@matthiasschaub matthiasschaub added the waiting for review This pull request urgently needs a code review label Sep 26, 2024
@mmerdes mmerdes self-requested a review September 26, 2024 12:33
mmerdes
mmerdes approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAICT ;)

The new structure is clearly an improvement and I could not find an obvious issue with the changes. The new regression tests are fine with the changes as well.

@matthiasschaub matthiasschaub merged commit 4403286 into main Sep 27, 2024
2 checks passed
@matthiasschaub matthiasschaub deleted the get_template branch September 27, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub left review comments

@mmerdes mmerdes mmerdes approved these changes

Assignees

@matthiasschaub matthiasschaub

Labels
waiting for review This pull request urgently needs a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gigaszi @mmerdes @matthiasschaub