Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number #168

Merged
merged 14 commits into from
Aug 7, 2023
Merged

Version number #168

merged 14 commits into from
Aug 7, 2023

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Aug 2, 2023

Related issues

Closes #145

Description

  • Apply the version number agreed in Choose a version number #145
  • Add a links field so that data can declare the version of the schema it is described by
  • Add exceptions to tests
  • Update schema URL

The schema URL will not resolve until the 0__2__0 tag is created and pushed. We'll only want to do that once we're ready to release version 0.2.0, but that isn't a blocker to merging this PR.

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit

If you added or removed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md

Having trouble?

See how to resolve check failures.

@duncandewhurst duncandewhurst marked this pull request as ready for review August 2, 2023 01:59
@duncandewhurst
Copy link
Contributor Author

@odscjames, @radix0000, heads up about this schema change that we discussed in yesterday's call. Also, reminder that OFDS uses the same links field to declare the version of the schema that describes a dataset, in case you need to borrow any code from its version of CoVE.

odscjen
odscjen previously approved these changes Aug 3, 2023
stufraser1
stufraser1 previously approved these changes Aug 4, 2023
matamadio
matamadio previously approved these changes Aug 4, 2023
@duncandewhurst
Copy link
Contributor Author

duncandewhurst commented Aug 6, 2023

@odscjen please can you approve and merge. The only change since the approvals was to resolve merge conflicts in the changelog. To avoid these repeated review requests, I've updated the branch protection settings so that stale approvals are not dismissed when new commits are pushed.

@odscjen odscjen merged commit 69dd313 into dev Aug 7, 2023
4 checks passed
@odscjen odscjen deleted the version-number branch August 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose a version number
4 participants