Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #3201 #3203

Merged
merged 4 commits into from
Dec 3, 2024
Merged

fixes #3201 #3203

merged 4 commits into from
Dec 3, 2024
+19 −5

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Dec 2, 2024 •
edited
Loading

Checks if the last character of a string retrieved from nf90_get_att is the C_NULL_CHAR and removes if it is when adding attributes to a FileMetadata object in NetCDF4_FileFormatter.F90

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🪲 Bug Something isn't working 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 2, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner December 2, 2024 19:48
weiyuan-jiang
weiyuan-jiang reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, we should replace all pfio_get_att_str with nf90_get_att and remove pfio_get_att_string

@mathomp4
Copy link
Member

mathomp4 commented Dec 3, 2024

I made a push to fix the ADAS CI issue.

@bena-nasa bena-nasa merged commit 7eb7786 into main Dec 3, 2024
36 checks passed
@bena-nasa bena-nasa deleted the hotfix/bmauer/fixes-#3201 branch December 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiyuan-jiang weiyuan-jiang weiyuan-jiang approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @mathomp4 @weiyuan-jiang